Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR starts wiring in the new BFT synchronizer path alongside the existing “simple” synchronizer, including adding a callback to prune committed requests from the SmartBFT mempool.
Changes:
- Adds BFT synchronizer factory/state fields to
Consensusand a newPruneRequestsFromMemPoolhook for synchronizer-driven pruning. - Creates (but does not yet replace usage with) a BFT synchronizer instance during consensus construction.
- Adds TODO notes around temporary append-listener usage and planned synchronizer migration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| node/ledger/consensus_ledger.go | Adds a TODO note indicating the append listener registration is temporary until BFT synchronizer migration. |
| node/consensus/consensus.go | Extends Consensus with BFT synchronizer plumbing and adds PruneRequestsFromMemPool for synchronizer-driven mempool pruning. |
| node/consensus/consensus_builder.go | Wires a BFT synchronizer factory and attempts to create a BFT synchronizer during CreateConsensus, while still using the existing synchronizer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tock-ibm
force-pushed
the
bft-synch-prune
branch
2 times, most recently
from
5cd1e50 to
5e266df
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com>
tock-ibm
force-pushed
the
bft-synch-prune
branch
from
5e266df to
5a2dac3
Compare
HagarMeir
reviewed
Mar 15, 2026
HagarMeir
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#35
Builds on top of #675
Adds a prune requests method to be given to the synchronizer